Repository navigation
Keep the saved case of a snippet typed in its shortcut case - #526
Merged
Merged
Conversation
Typing the default shortcut "FF" gave an all-caps expansion. The all-caps token rule changed snippet expansions too. Now a snippet expansion keeps its saved case when the saved shortcut starts with the typed all-caps token. Typing "BRB" for the shortcut "brb" still gives an all-caps expansion. The first-letter rule does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When you type the default snippet shortcut
FF, the suggestion shows the expansion in capitals: "CHECK OUT FLUENTTYPER, A PHENOMENAL ...". The background applies the all-caps rule for an all-caps token to every prediction, snippet expansions included. The handler also stores shortcuts in lowercase, so it cannot see thatFFis the saved case of the shortcut.Found while working on #524.
Change
PresageHandlernow keeps the shortcuts in their saved case.finalizePrediction, the all-caps rule does not change a snippet expansion when the saved shortcut starts with the typed all-caps token. This applies to an exact shortcut (FFforFF) and to a prefix (FFforFFX).FFfor the shortcutFFgives the expansion in its saved case.BRBfor the shortcutbrbstill gives "BE RIGHT BACK".asapgives "As soon as possible").Tests
test.eachintests/PresageHandler.snippets.test.ts. TheFFandFFXcases fail before the fix.bun run check,bun run test,bun run test:e2e,bun run check:e2e:coveragepass.🤖 Generated with Claude Code