Repository navigation
Fix Firefox flake in the Gutenberg caret e2e test - #527
Merged
Merged
Conversation
The Gutenberg caret test typed " wo" and used the first menu row that it saw. A menu for the shorter prefix " w" can show first. Before Tab, the menu changes to the " wo" list, and Tab inserts the top word of that list. The test then looked for the wrong word. This failed about 3 runs in 10 on Firefox. The writer and the caret are correct: the field and the saved blocks had the accepted word and "Z" after it. Read the accepted word from the field after Tab, in front of the text that was after the caret. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e test "Gutenberg acceptance leaves the caret after the inserted word in each prose field" failed about 3 runs in 10 on Firefox. This is a test race, not a product bug.
Cause
The test typed " wo" and used the first menu row that it saw. A menu for the shorter prefix " w" can show first. Before Tab, the menu changed to the " wo" list, and Tab inserted the top word of that list. The test then looked for the wrong word.
A diagnostic run on master showed this. For example, at
4 core/table middlethe test read "were", but the field and the saved blocks both had " wouldZ". The writer and the caret were correct. The "doubled word" inWe wouldZ saw teh table cell. wouldZis the word from the earlier "end" pass in the same field.Change
After Tab, the test reads the accepted word from the field: the word in front of the text that was after the caret. The test does not use the menu text that it read before Tab. No product change, no retries, no longer waits.
Verification
bun run check,bun run test,bun run test:e2e,bun run check:e2e:coverage: all pass.🤖 Generated with Claude Code