Repository navigation
List the person's projects in the agent's account - #920
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approved
The focused guidance change matches account-selection behavior and resolves the documented mismatch without identified blocking issues.
No open issues 🎉
What changed in this PR
Updates the connect skill’s fallback project listing to use the agent’s bound account, preventing multi-account logins from selecting projects in the wrong account.
Changes:
- Instructs fallback listing to pass
--accountusing the agent’s reportedaccount_id.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| skills/basecamp-connect/SKILL.md | Pins fallback project-listing guidance to the agent’s account. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #915, which merged before this last review fix landed.
When the agent can't list its own projects, the
basecamp-connectskill falls back to listing the person's projects with their login. That login can default to a different account than the agent's, and connector setup reads projects in the agent's bound account. For someone in more than one account, the serve-all default could then pick projects from the wrong account, and setup would fail.The fallback now passes
--accountwith theaccount_idthe agent'sauth statusreports. The skill already does the same when it reads the operator's name, for the same reason.From Copilot's review of #915 at
36a232bb, "Pin fallback project listing to the agent's bound account".bin/cipasses.Summary by cubic
Fixes the
basecamp-connectskill's fallback project listing so it scopes to the agent's bound account. When the agent can't list its own projects, the fallback lists the person's projects with their login, which can default to a different account and break connector setup for people in multiple accounts. The fallback now passes--accountwith theaccount_idthat the agent'sauth statusreports, matching what the skill already does when reading the operator's name.Written for commit 418bf66. Summary will update on new commits.