Skip to content

List the person's projects in the agent's account - #920

Merged
jeremy merged 1 commit into
mainfrom
connect-agent-account
Oct 20, 2026
Merged

jeremy merged 1 commit into
mainfrom
connect-agent-account

Conversation

@robzolkos

@robzolkos robzolkos commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #915, which merged before this last review fix landed.

When the agent can't list its own projects, the basecamp-connect skill falls back to listing the person's projects with their login. That login can default to a different account than the agent's, and connector setup reads projects in the agent's bound account. For someone in more than one account, the serve-all default could then pick projects from the wrong account, and setup would fail.

The fallback now passes --account with the account_id the agent's auth status reports. The skill already does the same when it reads the operator's name, for the same reason.

From Copilot's review of #915 at 36a232bb, "Pin fallback project listing to the agent's bound account".

bin/ci passes.


Summary by cubic

Fixes the basecamp-connect skill's fallback project listing so it scopes to the agent's bound account. When the agent can't list its own projects, the fallback lists the person's projects with their login, which can default to a different account and break connector setup for people in multiple accounts. The fallback now passes --account with the account_id that the agent's auth status reports, matching what the skill already does when reading the operator's name.

Written for commit 418bf66. Summary will update on new commits.

View guided diff Turn on auto-fix

@robzolkos
robzolkos requested a review from a team as a code owner October 20, 2026 01:25
Copilot AI balanced review requested due to automatic review settings October 20, 2026 01:25
@github-actions github-actions Bot added the skills Agent skills label Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The focused guidance change matches account-selection behavior and resolves the documented mismatch without identified blocking issues.

No open issues 🎉

What changed in this PR

Updates the connect skill’s fallback project listing to use the agent’s bound account, preventing multi-account logins from selecting projects in the wrong account.

Changes:

  • Instructs fallback listing to pass --account using the agent’s reported account_id.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File Description
skills/​basecamp-connect/​SKILL.md Pins fallback project-listing guidance to the agent’s account.

Review effort: Balanced

@jeremy
jeremy merged commit 9192e4d into main Oct 20, 2026
29 checks passed
@jeremy
jeremy deleted the connect-agent-account branch October 20, 2026 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skills Agent skills

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants