Let a box's number leave a thread opened from that box - #526
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Bundle and in-flight request paths remain untested, and the stated cleanup refactor is incomplete.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Updates mail box shortcuts so selecting the current box closes an open thread or overlay and returns to its loaded list.
Changes:
- Adds shared overlay cleanup during box switching.
- Preserves active postings reads.
- Adds thread and search shortcut tests.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
internal/tui/mail.go |
Updates box switching and overlay cleanup. |
internal/tui/tui_test.go |
Tests thread and search shortcut behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1803
to
1805
| v.closeOverlays() | ||
| if v.requests.kind != mailRequestPostings { | ||
| v.requests.cancel() |
Comment on lines
+1818
to
+1820
| // closeOverlays puts away everything a box's list can have open over it — a thread, a | ||
| // search, a bundle, the Previously Seen screen — leaving the list itself. | ||
| func (v *mailView) closeOverlays() { |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhh
force-pushed
the
tui-box-numbers-leave-thread
branch
from
September 29, 2026 20:02
b77d4f9 to
205e35f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pressing
1inside a thread opened from the Imbox did nothing, and so did2inside a thread opened from The Feed.switchBoxtreated the box already under the thread as "already there" and answered with nothing. The model then passed the key on to the thread, which swallowed it.1while the Imbox is still loading doesn't throw that load away.switchBoxnow shares them throughcloseOverlays.TestMailViewBoxShortcutNoOp).New tests open a thread through the model and press
1and2, and check that1over a search in the Imbox returns to its list.🤖 Generated with Claude Code