Repository navigation
Conversation
The plugin's skills run the basecamp command, which people install from releases, but the entry installed whatever was on basecamp-cli's main. Between releases a fresh install got skills calling commands no released CLI had. basecamp-cli's release workflow now fast-forwards a stable branch to each stable release once it has published, so pointing the entry and its alias at stable keeps the plugin on the latest release with nothing to change here when a release ships.
There was a problem hiding this comment.
🟢 Approved
Both entries consistently select stable, the documentation matches, and no blocking issues were identified.
No open issues 🎉
What changed in this PR
Aligns Basecamp plugin skills with released CLI versions by installing from stable instead of main.
Changes:
- Sets
ref: stablefor bothbasecamp-cliand itsbasecampalias. - Updates the README link and explains release-driven branch promotion.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| README.md | Documents stable-branch installation and updates the plugin link. |
| .claude-plugin/marketplace.json | Selects stable for both Basecamp entries. |
Review effort: Balanced
Open
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
basecamp-clientry, and itsbasecampalias, install whatever is on basecamp-cli'smain(marketplace.json L10–L24 @ 663bcac). The plugin's skills run thebasecampcommand, which people install from releases. So between releases, a fresh install can get skills that call commands no released CLI has. 4, 5 and 8 commits touched basecamp-cli'sskills/in the last three release cycles.What
"ref": "stable".bin/check-marketplacerequires the alias to sharebasecamp-cli's source, so they change together.stableto each stable release once it has published (basecamp/basecamp-cli#925). After that, a release changes nothing in this repo.basecamp-clilink points atstable.HEY, Fizzy and the house-skills plugins are unchanged. HEY and Fizzy could do the same once their release workflows promote a
stablebranch.This replaces #12, which pinned commit shas with an hourly workflow here. With a
stablebranch, nothing lags a release by up to an hour, and nobody has to merge a PR here for each release.Ready to merge
stablealready exists in basecamp-cli atv0.14.0(2dbca87a), the latest release. That's also whatmainis today, so merging this changes nothing anyone installs until the next release.Verified locally
bin/check-marketplacepasses, and so doesclaude plugin validate .. Its only warning, a missing marketplace description, is already onmain.CLAUDE_CONFIG_DIRwith this branch as the marketplace:basecamp-cliandbasecampboth installed0.14.0at2dbca87a.CODEX_HOME:basecamp-cliinstalled0.14.0, and itsbasecamp-connect/SKILL.mdis byte-identical to v0.14.0's.stableandmainare the same commit today, I also pointed a scratch copy of this marketplace atv0.13.2. Claude Code installed0.13.2atd742884a, and Codex installed0.13.2with v0.13.2'sbasecamp-connectskill.stableonly moves forward. On the new branch, setting it to the commit it already points at succeeds, which is what a re-run of the release job does. Setting it back to v0.13.2 withforce=falsewas refused withUpdate is not a fast forward(HTTP 422), andstablestayed at v0.14.0.Companion: basecamp/basecamp-cli#925. Card: https://app.basecamp.com/2914079/buckets/48521764/card_tables/cards/10423396016