Repository navigation
Conversation
… shade lighter, for green text on it
…own (the trash, the health report's to-dos)
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sesh ui's highlight colour was a purple; the logo (docs/assets/sesh_logo.png) is blue. Now the app uses the logo's blue, so the README goes logo → screenshots → app in one colour.
#6E40C9#1165B1, the logo's blue (sampled from the PNG)#B392F0#63ADEE, the same hue, lighter#0D1117(was 7.5)#F3EEFF/#2A2140#ECF3FB/#13233A#1B1325#0B1A2BText drawn on the selected row passes WCAG's 4.5:1 in both modes: green (a TOTP code) on the light selection is 4.54:1, which is why it's
#ECF3FBand not a shade darker (the old purple's was 4.47). The API key mark (◆, not text) on it is 4.35:1, over the 3:1 for marks.Also fixed, found in review: a menu's selected row (Ctrl-G, Ctrl-K) showed only its ▌ bar, not the band, because the styled label inside reset the background put around the whole row. The selected row is now drawn by one function that puts the label's style (band and bold) back after every reset inside it, so rows whose labels have colours of their own (the trash's details, the health report's to-dos) stay on the band, and bold, too. Two tests follow each character's background: across a menu's row, and through a coloured label (each fails on the old code).
The README's three screenshots are taken again with it, from a real
sesh uisession on a made-up vault (example.com / example.org addresses, AWS's documentation account IDs), with a neutral dark frame. Checked by hand in the terminal.