Repository navigation
internal/compat: files made by v0.1.1, and tests that sesh still reads them - #221
Merged
Merged
Conversation
…tests that sesh still reads them
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…vault's layout, and syncing and joining; AGENTS.md says to add a release's files and never loosen these tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since v0.1.0, what a released sesh wrote must keep working. This makes CI check it.
internal/compat/testdata/v0.1.1/: a vault, an encrypted export and a sync folder, written by the released v0.1.1 (make.sh, kept with them, remakes them from the v0.1.1 binary). All made-up: GitHub (a URL, notes, a plain and a secret field, a folder, a tag, two earlier passwords), its TOTP, an API key, a note, a file, and an entry in the trash; usernames on example.com/.org; master and export passwords written in the test; the computer namedtest-laptop(sync records which computer made each change, and anyone can open these files with the test's password). Checked for anything personal: none.compat_test.go: the vault opens and every entry, its details, its earlier passwords and the trash read back; the export imports into a new vault; every sync file opens with the vault's key. Faking a careless change (a column added to the v1 schema, read by the code, with no upgrade step) fails the vault test with "no such column"; undone, it passes.migrateVN, never an edit to an old one, and these tests passing.