Conversation
alexeagle
marked this pull request as ready for review
September 16, 2026 17:59
alexeagle
requested review from
gregmagolan,
jbedard and
mattem
as code owners
September 16, 2026 17:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alexeagle
changed the title
jbedard
reviewed
Sep 16, 2026
| build_content += """ | ||
| build_content += """ | ||
| load("@rules_cc//cc:defs.bzl", "cc_library") | ||
| cc_library( |
Collaborator
There was a problem hiding this comment.
Do you just want access to the files or are you explicitly looking for the compiled cc_library?
We could always put the files into a filegroup but keep the cc_library behind the flag 🤷
jbedard
reviewed
Sep 16, 2026
| build_content += """ | ||
| build_content += """ | ||
| load("@rules_cc//cc:defs.bzl", "cc_library") | ||
| cc_library( |
Collaborator
There was a problem hiding this comment.
Should this be tagged as manual? Even without your change, but especially after it...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
include_headers = Truecurrently creates the generated:headerscc_libraryand also wires it intoNodeInfo. That makes every consumer of the Node toolchain depend on C++ toolchain resolution.Some native consumers only need to reference the headers explicitly and should not add that dependency to unrelated Node targets.
Change
Always generate the standalone
:headerstarget, while preserving the existing conditionalNodeInfo.headersbehavior. Users can depend directly on@nodejs_<platform>//:headerswithout enablinginclude_headers.The existing
include_headers = Truebehavior remains unchanged.Test
bazel test //:using_headers_test --test_output=errorsfrome2e/headers