Repository navigation
crate_universe: use local paths for vendored crate aliases - #4314
Open
goutamadwant wants to merge 1 commit into
Open
goutamadwant wants to merge 1 commit into
goutamadwant wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix local
crates_vendoralias generation for path dependencies in localvendor mode.
When a crate is patched to a local path, generated hub aliases and entries
from
crate_deps()now target the in-repository Bazel package instead of anexternal repository label. Local labels are constructed through a shared
validated path so malformed or escaping paths return a rendering error.
The local-patching integration fixture now exercises both the generated hub
alias and the
crate_deps()lookup for a patchedgetrandomdependency.Fixes #3732
Tests:
bazel test //crate_universe:unit_test --nocache_test_resultsbazel build //crate_universe:unit_test --config=rustfmt --config=clippybazel test //local_patching:test //local_patching:crate_deps_testAI agents assisted with understanding the codebase, writing tests, and reviewing the solution.