Repository navigation
Fix extra_exec_rustc_flags fallback in rust.toolchain - #4317
Open
thirtyseven wants to merge 1 commit into
Open
thirtyseven wants to merge 1 commit into
thirtyseven wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The choice between the flat extra_exec_rustc_flags and extra_exec_rustc_flags_triples tested extra_rustc_flags instead of extra_exec_rustc_flags, so a flat extra_exec_rustc_flags was silently dropped unless a flat extra_rustc_flags was also set.
thirtyseven
force-pushed
the
fix-extra-exec-rustc-flags-fallback
branch
from
October 5, 2026 23:44
70785c6 to
f0b2a85
Compare
MarcusSorealheis
approved these changes
Oct 13, 2026
MarcusSorealheis
left a comment
MarcusSorealheis
left a comment
There was a problem hiding this comment.
Not a maintainer here but this one is correct.
Ahajha
approved these changes
Oct 13, 2026
Contributor
|
Thanks for catching this! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3911 added
extra_exec_rustc_flags_triplestorust.toolchain, but the line choosing between it and the flatextra_exec_rustc_flagstests the wrong attribute:As a result:
extra_exec_rustc_flagswith no flatextra_rustc_flagsis silently dropped. The emptyextra_exec_rustc_flags_triplesdict is passed instead, and_get_flags_for_triplereturnsNonefor every triple. This includes configs that useextra_rustc_flags_triples, so it is a regression since 0.71.0 for anyone who already used the flat attribute.extra_exec_rustc_flags_triplestogether with a flatextra_rustc_flagsis ignored, because the empty flat list is passed instead.This change tests
extra_exec_rustc_flags, matching theextra_rustc_flagsline above it.🤖 Generated with Claude Code