Skip to content

Additional Source from Ovirt - #599

Open
ekrichbaum wants to merge 14 commits into
bb-Ricardo:mainfrom
ekrichbaum:Ovirt
Open

ekrichbaum wants to merge 14 commits into
bb-Ricardo:mainfrom
ekrichbaum:Ovirt

Conversation

@ekrichbaum

Copy link
Copy Markdown

Previous pull request wasn't adopted. Rebased against other changes and re-added source with doucmentation. Broke Ovirt and Openstack out to individual subs.

Added oVirt / Red Hat Virtualization as a source type and included relevant installation documentation.
Added a method to check if an object is synced by another source based on ownership and tags.
Added configuration options for oVirt integration.
This file defines the OVirtConfig class, which manages configuration options for connecting to the oVirt API, including authentication, TLS settings, and filtering options for syncing with NetBox.
Added support for optional oVirt installation in Dockerfile.
Removed the method object_synced_by_other_source from the connection.py file, which checked if a NetBox object was maintained by a different configured source.
@bb-Ricardo

Copy link
Copy Markdown
Owner

Hi @ekrichbaum,

thank you for not giving up and resubmitting your contributions.

With the Hetzner source we agreed that @SerhiiZahuba will take care of issues and feature requests. Same question would be here, if you would like to be code owner for the Ovirt and Openstack sources? Mostly due to the lack of a testing environment we are not able to easily reproduce errors and therefore would make debugging really difficult.

regarding the PR's:

  • not sure if we have it documented already: you can recreate the config by simply running rm settings-example.ini && ./netbox-sync.py -g -c settings-example.ini
  • it is fantastic that you added a docs document to this PR but not sure if intentional or not, it missing in the Openstack PR
  • are you aware of Ovirt or Openstack mockup services (similar to vcsim), which you could use to create integration tests? It would be fantastic to add these as well (if possible).

@ekrichbaum

Copy link
Copy Markdown
Author

I swore I put a response in. Absolutely on these sources. Once I finish my AWS source, I'll get it posted as well, before I go back to a Digital Ocean version. I split them to be a little more obvious but of course missed that documentation item. I'm not aware of a mockup environment. I'm running against dev/staging/prod versions of the platforms in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants