Repository navigation
aws: add EC2/EBS/ENI discovery source with optional S3, Lambda, EKS, and Organizations support - #608
Merged
Merged
Conversation
…and Organizations support Read-only boto3 discovery of EC2 instances, EBS volumes, and network interfaces, with VPC-scoped VRF/IP import. Supports explicit or auto-discovered regions, single-account or AWS Organizations scanning via per-account role assumption, and optional S3, Lambda, and EKS inventory. Authorization denials are tolerated per account/region/ service/resource and reconciled into NetBox tags so partial access doesn't abort a run or prune objects the source couldn't see this time.
Closed
|
This was a materially different set of client.py and connection.py items. there are some helpers and other items here but a lot of my protections and adjustments were removed from client.py. connection.py seems more limited with a catch around a ValueError, but again changed the collision logging and other elements. It will take some time to evaluate and compare items for the real world. It would have been preferable to note on the first PR those adjustments or needs prior to this point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a read-only AWS source, supersedes #603 (stalled on a fork branch with a broken circular self-import and a never-committed
AWSClient).What this adds
regions = autodiscovery.Sync:AccessDenied:<Operation>NetBox tag, instead of aborting the whole run or pruning objects the source just couldn't see this time.docs/source_aws.mdwith required read-only IAM permissions, Organizations setup, and the authorization-denial contract.Testing
tests/test_aws_source.py+tests/test_aws_services.py, ~190 cases againstbotocore.stub.Stubber(pagination, access-denied semantics, Organizations, S3/Lambda/EKS, name collisions) — no AWS credentials needed.development.Closes #603.