surface malformed TSTInfo as TSPException in TimeStampToken - #2415
Open
rootvector2 wants to merge 1 commit into
Open
surface malformed TSTInfo as TSPException in TimeStampToken#2415rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
hubot
pushed a commit
that referenced
this pull request
Sep 5, 2026
… other than one signer, as the TSPException its constructor declares rather than letting an unchecked exception out through the TimeStampResponse byte[] and InputStream paths, and asn1.tsp.TSTInfo requires the five to ten elements RFC 3161 sec. 2.4.2 gives the type so a short sequence is refused rather than running its enumeration out, relates to github #2415.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimeStampTokenparses the attacker-controlledTSTInfoeContent inside a try that catches onlyCMSException, so a well-formedTimeStampRespcarrying a malformedTSTInfo(empty/shortSEQUENCE, a non-SEQUENCE, or truncated DER) lets an uncheckedIllegalArgumentException/ClassCastException/NoSuchElementExceptionescape theTimeStampResponse(byte[])/(InputStream)path's declaredthrows TSPException, IOException— the siblingTimeStampResponse(DLSequence)ctor already wrapsnew TimeStampToken(...), so this rethrows the parse failure asTSPExceptionto match it.