fix issue 313 by adding the missing completion signature - #314
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, targeted to the reported issue, and includes a focused regression test covering the fix.
Pull request overview
Fixes issue 313 by correcting the reported completion signatures for counting_scope_join so they include set_stopped, and adds a regression test to ensure co_await scope.join() compiles/works as expected.
Changes:
- Extend
counting_scope_join_t::get_completion_signatures()to includeset_stopped_t(). - Add a new regression test (
issue-313.test.cpp) and register it in the execution tests CMake list. - Silence an unused-result warning in an existing stop-token test via
(void)std::exchange(...).
File summaries
| File | Description |
|---|---|
| tests/beman/execution/thread-stoptoken-intro.test.cpp | Explicitly discards std::exchange return value to avoid unused-result diagnostics. |
| tests/beman/execution/issue-313.test.cpp | New regression test exercising co_await scope.join() (issue 313). |
| tests/beman/execution/CMakeLists.txt | Registers the new issue-313 test target. |
| include/beman/execution/detail/counting_scope_join.hpp | Adds missing set_stopped_t() to counting_scope_join completion signatures. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.