Skip to content

fix issue 313 by adding the missing completion signature - #314

Merged
dietmarkuehl merged 1 commit into
mainfrom
fix-issue-313
Sep 5, 2026
Merged

fix issue 313 by adding the missing completion signature#314
dietmarkuehl merged 1 commit into
mainfrom
fix-issue-313

Conversation

@dietmarkuehl

Copy link
Copy Markdown
Member

No description provided.

@dietmarkuehl
dietmarkuehl requested a review from camio as a code owner September 5, 2026 22:24
Copilot AI lite review requested due to automatic review settings September 5, 2026 22:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is small, targeted to the reported issue, and includes a focused regression test covering the fix.

Pull request overview

Fixes issue 313 by correcting the reported completion signatures for counting_scope_join so they include set_stopped, and adds a regression test to ensure co_await scope.join() compiles/works as expected.

Changes:

  • Extend counting_scope_join_t::get_completion_signatures() to include set_stopped_t().
  • Add a new regression test (issue-313.test.cpp) and register it in the execution tests CMake list.
  • Silence an unused-result warning in an existing stop-token test via (void)std::exchange(...).
File summaries
File Description
tests/beman/execution/thread-stoptoken-intro.test.cpp Explicitly discards std::exchange return value to avoid unused-result diagnostics.
tests/beman/execution/issue-313.test.cpp New regression test exercising co_await scope.join() (issue 313).
tests/beman/execution/CMakeLists.txt Registers the new issue-313 test target.
include/beman/execution/detail/counting_scope_join.hpp Adds missing set_stopped_t() to counting_scope_join completion signatures.
Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 93.403% (-0.05%) from 93.454% — fix-issue-313 into main

@dietmarkuehl
dietmarkuehl merged commit b411078 into main Sep 5, 2026
43 checks passed
@dietmarkuehl
dietmarkuehl deleted the fix-issue-313 branch September 5, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants