Report incomplete guidance loading - #293
Merged
Merged
Conversation
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: improvement
User Impact: Users and agents can distinguish missing guidance from guidance excluded by loading errors.
Problem: Invalid files could disappear behind a complete-menu claim, while some filesystem and glossary errors looked like absent content.
Solution: Expose skipped-file diagnostics through gather, pull, and review, report actual menu completeness, and fail on unreadable directories or malformed present glossaries. Keep invalid checks out of generation diagnostics.
Compatibility: Breaking API change:
contract.completeness.completewidens from literaltruetoboolean; consumers must check it. Healthy results includediagnostics: []. Partial loads keep their success status; all-miss CLI pulls keep empty stdout and exit 2. No on-disk migration.Scope: One of five independent PRs split from the original #291. This branch targets
mainand contains only this concern, its tests, and its documentation.Related: Enforce resolved material access boundaries, Preserve guidance meaning in CLI output, Add read-only installed skill checks, Fix and validate rendered guidance examples.
Validation:
pnpm run quality:all: passed on this standalone branch, including build, package/release checks, tests (246 passed), workspace builds, and package validations.git diff origin/main...HEAD --check: passed.Changeset: Existing minor changeset retained, with the breaking API change labeled for the 0.x preview.
ghost Review: Review packet assembled against
apps/docs/.ghost. This package does not bind the changed CLI/test/docs files, so the packet is coverage context, not a passing brand review. Used the currentghost review --package apps/docs/.ghost --base origin/main --format jsonand inspectedghost manifest; the olderghost check,--include-memory, anddump:cli-helpworkflows are unavailable in this checkout.File changes (16 files)
.changeset/visible-load-diagnostics.mdpackages/ghost/README.mdpackages/ghost/src/commands/gather-command.tspackages/ghost/src/commands/pull-command.tspackages/ghost/src/embed/gather.tspackages/ghost/src/embed/pull.tspackages/ghost/src/embed/snapshot.tspackages/ghost/src/embed/types.tspackages/ghost/src/internal/load-diagnostics.tspackages/ghost/src/review/review-packet.tspackages/ghost/src/scan/check-files.tspackages/ghost/src/scan/node-files.tspackages/ghost/src/skill-bundle/SKILL.mdpackages/ghost/src/skill-bundle/references/ground.mdpackages/ghost/src/skill-bundle/references/schema.mdpackages/ghost/test/load-diagnostics.test.tsScreenshots/Demos: N/A: no visual surface changes.