Repository navigation
core: frontend: notifications: Group notifications by service - #4589
Merged
patrickelectric merged 2 commits intoOct 14, 2026
Merged
Conversation
patrickelectric
approved these changes
Oct 14, 2026
patrickelectric
left a comment
patrickelectric
left a comment
Member
There was a problem hiding this comment.
Can we break this at least in two commits ? one for the components that are under the notifications folder and another one for the store ?
AlejoPm03
force-pushed
the
group-notifications
branch
from
October 14, 2026 17:50
aeb61e6 to
71fdbae
Compare
joaoantoniocardoso
added
the
move-to-stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion to improve the readability of errors, mainly when a service is not working properly
Related to #4204
Currently, errors are shown in a window of 1 minute by default, and the time-ago resolution is also 1 minute, so I believe it is not that important to have a strict temporal order between the notifications of different services.
I think it is more useful to take a quick look at the notifications and see which service notified. If a service has a lot of errors, instead of flooding the notifications, it stays collapsed and shows only the notification types.
notifications.mp4