Repository navigation
[1.4] beacon: add tests - #4594
Merged
joaoantoniocardoso merged 2 commits intoOct 15, 2026
Merged
joaoantoniocardoso merged 2 commits into
joaoantoniocardoso merged 2 commits into
Conversation
Automated PR Review0. Summary
Backport of PR #4570 to No further comments, nice job 👍 Generated by PR Review Bot. This is advisory, a human reviewer must still approve. |
Member
_____________ ERROR collecting core/services/beacon/test_beacon.py _____________
ImportError while importing test module '/home/runner/work/BlueOS/BlueOS/core/services/beacon/test_beacon.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.11.17/x64/lib/python3.11/importlib/__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
core/services/beacon/test_beacon.py:14: in <module>
from starlette.requests import Request
E ModuleNotFoundError: No module named 'starlette' |
The 1.4 test environment does not provide starlette, fastapi, uvicorn, zeroconf or commonwealth, so the tests failed at import time. Replace them with stand-ins and load the real commonwealth settings manager by path, keeping the settings tests meaningful. Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
joaoantoniocardoso
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the beacon tests to 1.4-dev.
Cherry-pick of #4570