Skip to content

[1.4] helper: add missing f prefix in exception messages and fix a typo - #4597

Merged
joaoantoniocardoso merged 2 commits into
bluerobotics:1.4-devfrom
patrickelectric:fix-helper-f-prefix-14
Oct 14, 2026
Merged

joaoantoniocardoso merged 2 commits into
bluerobotics:1.4-devfrom
patrickelectric:fix-helper-f-prefix-14

Conversation

@patrickelectric

Copy link
Copy Markdown
Member

Exception messages in the helper printed the literal placeholders instead of the values.

Cherry-pick of #4595

@joaoantoniocardoso
joaoantoniocardoso enabled auto-merge (rebase) October 14, 2026 17:58
@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Cherry-pick of #4595 into 1.4-dev. Adds the missing f prefix to two exception-detail format strings in core/services/helper/main.py (hardware_id and software_id) so the real exception value is interpolated instead of the literal {exception} text, and fixes a typo (bse → be) in the /software_id endpoint summary.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@joaoantoniocardoso
joaoantoniocardoso merged commit 9b579c3 into bluerobotics:1.4-dev Oct 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants