Skip to content

Move date utility equations to a separate crate - #754

Open
nekevss wants to merge 5 commits into
mainfrom
separate-utils
Open

nekevss wants to merge 5 commits into
mainfrom
separate-utils

Conversation

@nekevss

@nekevss nekevss commented Oct 20, 2026

Copy link
Copy Markdown
Member

This is meant to primarily separate the date utils from living in the timezone_provider.

@Manishearth

Copy link
Copy Markdown
Contributor

Can we call this temporal_utils or something? I think timezone_provider is already confusing since it's temporal-specific but that's not clear.

Overall for this type of thing I'm not sure if we need a separate crate. It's fine by me if the utils live in timezone_provider for now.

@nekevss

nekevss commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

I'm fine with temporal_utils. It was one of the options on the short list.

I'd prefer not to have these solely in timezone_provider. It gets a bit confusing at times and it makes them unavailable for use in the zoneinfo crate.

@Manishearth

Copy link
Copy Markdown
Contributor

Okay, fair enough!

@jedel1043 jedel1043 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! nice refactor

@jedel1043
jedel1043 enabled auto-merge (squash) October 29, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants