Repository navigation
Add TemporalParser and move parsed_intermediates under parsers - #755
Merged
Merged
Conversation
jedel1043
approved these changes
Oct 30, 2026
| /// | ||
| /// `ToTemporalInstant` runs no observable operations after parsing, so the | ||
| /// result is validated here rather than handed back as an intermediate. | ||
| #[must_use = "parsing returns the parsed instant"] |
Member
There was a problem hiding this comment.
Do we need these must_use? Result and Option are already marked as must_use, so adding these might be unnecessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #224.
It creates a
TemporalParserthat also allows us to support parsing UTF16.