bootc-ubuntu-setup: Preserve the original runner OS identity - #54
Merged
cgwalters merged 1 commit intoSep 11, 2026
Conversation
cgwalters
requested review from
gursewak1997
and
a balanced review from Copilot
September 10, 2026 22:13
Installing Plucky packages can replace base-files and change os-release from Ubuntu 24.04 to 25.04. Reading it again afterward incorrectly skips the fixed Resolute QEMU installation. Capture the initial identity once and retain it for package selection. Assert the installed QEMU version in virtualization tests so a silently skipped upgrade cannot pass solely because a guest boots. Generated-by: AI Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters-bot
force-pushed
the
fix-initial-runner-os
branch
from
September 10, 2026 22:13
78e947a to
6b1dc87
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The implementation directly addresses the reported regression and adds a strict version assertion covering the failure mode.
Pull request overview
Preserves the runner’s original Ubuntu identity across package upgrades, ensuring correct package selection and QEMU installation.
Changes:
- Captures the initial OS identity before package changes.
- Uses that identity for package and QEMU guards.
- Verifies QEMU 10.2 or newer in virtualization tests.
File summaries
| File | Description |
|---|---|
bootc-ubuntu-setup/action.yml |
Preserves and reuses the original runner OS identity. |
.github/workflows/test-virtualization.yml |
Adds architecture-aware QEMU version validation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gursewak1997
approved these changes
Sep 10, 2026
cgwalters
merged commit Sep 11, 2026
4725f09
into
bootc-dev:support-ubuntu-2604-signoff
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #52 (
support-ubuntu-2604-signoff); merge that first, then retarget this PR tomain.Fix the OS guard introduced in #53. Installing the Plucky virtualization packages can replace
base-files, which rewrites/usr/lib/os-release. The original Ubuntu 24.04 runner then reports 25.04, and our late OS check incorrectly skips the fixed Resolute QEMU.The affected PR-2290 job records:
Capture the original identity in a composite-step output before any package changes. Use it for both #52's Ubuntu 24/26 package selection and the later QEMU guard. Native Ubuntu 26.04 retains its existing package path. Assert the installed QEMU version in the virtualization tests so silently retaining 9.2.1 cannot pass merely because a guest happens to boot.
Validation
1:9.2and accepts1:10.2with Debian's actualdpkg.actionlint, extracted shell checks, and whitespace checks passed. The local actionlint version does not yet recognize bootc-ubuntu-setup: Add support for ubuntu-26.04 runners #52'subuntu-26.04runner label; those diagnostics are unchanged from the parent branch.ubuntu:26.04image: installed QEMU1:10.2.1+ds-1ubuntu3.2contains theVHOST_USER_NEED_REPLY_MASK/process_message_reply()ordering fix from upstream1ba9a522. Its packaged amd64 emulator passed a bounded TCG + slirp + virtio-net startup check. This was not a native arm64 or full bootc integration test.Generated-by: AI
Implementation and regression fixtures were AI-generated and independently AI-reviewed. Human review and DCO signoff are still required; no Signed-off-by was added automatically.