feat(preview): Pass version actions into the comparison banner by zhirongwang · Pull Request #4900 · box/box-ui-elements

zhirongwang · 2026-10-13T22:10:46Z

Summary

The versions sidebar registers download, make current, and delete for the compared version.
Those handlers are merged onto the existing comparison banner that the preview already reads.
If the sidebar loads after the compared pane opens, the banner updates without reloading the file.

Test Plan

With version history open, Make Current, Download, and Delete on the compared pane run the same actions as the version row menu for that version.
Download fetches that version, not the current file.
Open full preview from the host is still available on the banner.
Closing version history removes those three actions.

Made with Cursor

Summary by CodeRabbit

New Features
- Comparison previews can display actions for the selected version, including download, make current, or delete when permitted and applicable.
- Version sidebar actions reflect permissions, download availability, retention, archive status, and version limits, keeping available actions consistent with each version’s state.
Bug Fixes
- Comparison banners and preview modes update in an open preview without reloading, while retaining other banner information and clearing stale version selections when comparison starts.

coderabbitai · 2026-10-14T02:03:10Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Last reviewed commit: afbaf83
Latest commit, not reviewed: b916b80

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: dbad1c63-3f74-40ad-a7cb-ceef7f428860

📥 Commits

Reviewing files that changed from the base of the PR and between 47e799b and afbaf83.

📒 Files selected for processing: 1

src/elements/content-preview/ContentPreview.js

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Walkthrough

The versions sidebar registers version actions and state with the comparison preview. The preview selects eligible actions for the compared version, combines them with host banner data, and passes the banner to both panes. It also updates comparison mode and banner props when supported without reloading the preview.

Changes

Comparison Banner Actions

Layer / File(s)	Summary
Version visibility and comparison action selection `src/elements/content-sidebar/versions/flowTypes.js`, `src/elements/content-sidebar/versions/versionItemActionVisibility.js`, `src/elements/content-sidebar/versions/VersionsItem.js`, `src/elements/content-sidebar/versions/__tests__/versionItemActionVisibility.test.js`	A shared helper derives version-item action visibility and selects eligible delete, download, and promote actions for a compared version. Tests cover missing, current, restricted, deleted, archived, retained, and over-limit versions.
Sidebar action registration `src/elements/content-sidebar/versions/VersionsSidebarContainer.js`, `src/elements/content-sidebar/versions/__tests__/VersionsSidebarContainer.test.js`	The sidebar publishes its version handlers and state on mount and when relevant state changes. It clears registration on unmount. Tests cover default state, loaded versions, and cleanup.
Comparison preview banner and mode updates `src/elements/content-preview/ContentPreview.js`	The comparison preview combines host banner data with selected version actions and passes the banner to both panes. It updates comparison mode and banner props when supported and no reload is needed.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant VersionsSidebarContainer
  participant ContentPreviewWithComparison
  participant selectComparisonBannerActions
  participant PreviewPanes
  VersionsSidebarContainer->>ContentPreviewWithComparison: register version actions
  ContentPreviewWithComparison->>selectComparisonBannerActions: select actions for compared version ID
  selectComparisonBannerActions-->>ContentPreviewWithComparison: eligible version actions
  ContentPreviewWithComparison->>PreviewPanes: pass combined comparison banner

Suggested reviewers: abhishek1128, ahorowitz123

Merge Risk: ⚪ Minimal · up to afbaf

No actionable merge-blocking issue is established. Confirm that late sidebar registration updates the banner in the supported preview before release.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 7 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: passing version actions into the comparison banner.
Description check		The description explains the change and includes a focused test plan covering the main objectives. The listed test items are unchecked, but the description is otherwise complete and relevant.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit checks each version's role
Then sends the actions down the scroll
The banner keeps its host details
Both panes receive the chosen trails
The sidebar clears when it departs}

_{Comment @coderabbitai help to get the list of available commands.}

The versions sidebar registers download, make current, and delete for the compared version on the existing comparison banner.

kduncanhsu · 2026-10-17T00:06:39Z

+
+        // Sidebar handlers override the host's; a handler the sidebar withholds keeps the host's.
+        return {
+            ...hostComparisonBanner,


Once the sidebar has registered, drop the host's onDownload, onDelete, and onMakeCurrent before applying selectComparisonBannerActions. A withheld action currently leaves the host handler in place, so the compared-pane menu can still download or delete a version the row would not allow.

kduncanhsu · 2026-10-17T00:07:14Z

+            ...hostComparisonBanner,
+            ...selectComparisonBannerActions(versionActions, comparedVersionId),


saw this after leaving my comment above - did we address this? I don't see the changes made in commit d26c70a, they seem to have been removed

zhirongwang self-assigned this Oct 13, 2026

zhirongwang marked this pull request as ready for review October 14, 2026 02:02

zhirongwang requested review from a team as code owners October 14, 2026 02:02

box deleted a comment from coderabbitai Bot Oct 14, 2026

This comment was marked as outdated.

Sign in to view

zhirongwang mentioned this pull request Oct 16, 2026

docs(comparison): Mark updateComparisonBanner as public box/box-content-preview#1850

Open

1 task done

feat(preview): Pass version actions into the comparison banner

b916b80

The versions sidebar registers download, make current, and delete for the compared version on the existing comparison banner.

zhirongwang force-pushed the comparison-banner-version-actions branch from 2ec8f0c to b916b80 Compare October 16, 2026 23:02

kduncanhsu reviewed Oct 17, 2026

View reviewed changes

Navigation Menu

Repository navigation

feat(preview): Pass version actions into the comparison banner - #4900

feat(preview): Pass version actions into the comparison banner#4900
zhirongwang wants to merge 1 commit into
box:masterfrom
zhirongwang:comparison-banner-version-actions

zhirongwang commented Oct 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading

Reviews paused

Uh oh!

This comment was marked as outdated.

Uh oh!

kduncanhsu Oct 17, 2026

Uh oh!

kduncanhsu Oct 17, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		...hostComparisonBanner,
		...selectComparisonBannerActions(versionActions, comparedVersionId),

Conversation

zhirongwang commented Oct 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

This comment was marked as outdated.

Uh oh!

kduncanhsu Oct 17, 2026

Choose a reason for hiding this comment

Uh oh!

kduncanhsu Oct 17, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zhirongwang commented Oct 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 14, 2026 •

edited

Loading