Repository navigation
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe sidebar now hides the Box Sign navigation item when Box Sign is enabled and ChangesBox Sign Navigation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
|
Gustavo Bueno seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
What
Adds a new optional
isForcedToUseTemplatesproperty tosignSidebarProps. When true, the Box Sign entry point in the sidebar nav is suppressed, even if Box Sign is otherwise enabled.Why
Gives the consuming app fine-grained control to hide the Box Sign sidebar button in flows where users are forced to use templates.
How
isForcedToUseTemplates?: booleanto theSignSidebarPropsinterface (SidebarNavSign.tsx).SidebarNav.jsand updated the render gate fromhasBoxSign &&tohasBoxSign && !isForcedToUseTemplates &&.Testing
SidebarNavtest asserting the Box Sign button is not rendered whenisForcedToUseTemplates=truedespiteenabled=true.SidebarNavtests pass.Summary by CodeRabbit