Repository navigation
fix(ssh): recover Brev includes scoped to unrelated hosts - #507
Conversation
|
Full qualification is currently blocked by existing main-branch CI failures. Linked prerequisite: #508 fixes the enterprise-disallowed notification action in the test workflow and stale HTTPResponseError assertions after merged #484. The SSH repair remains scoped to its two files. GitHub has held the fork workflows for maintainer approval. A maintainer with Actions write authority needs to approve the runs on #508 and this PR. My account has read-only upstream access, so it cannot approve those runs or the code-owner review. No unchanged workflow reruns or new repair pushes have been triggered. Published SSH candidate: |
Signed-off-by: Deepak Jain <deepujain@gmail.com>
ed93a09 to
0c65a8f
Compare
|
The CI prerequisite #508 merged as The two-file SSH patch is identical to the previous candidate ( All eight normal upstream workflows were created for the new head and report Production QA acceptance for NVIDIA/NemoClaw#13090 remains separate: both original UI setup paths, refresh/reconnect, host/provision/adapter checks, onboarding and a real agent response still need confirmation. |
|
Qualification update for approved head The one failing check is CLI Output Compatibility, attempt 2: Please rerun only the failed compatibility workflow once to check this intermittent failure. I have no upstream Actions write authority. The approved SSH candidate is preserved; no empty commit, source change or workflow rerun has been triggered by me. Limitations retained: Codecov uploads returned HTTP429 (coverage HTML/output artifacts are present, digest-verified and inspected); CodeQL succeeds with no new changed-code alerts but scans165/271 Go files and reports deprecated v2 actions. No absent automated review is claimed passing. Full CI is not declared green while compatibility is failing. Both original production UI paths and QA acceptance for NVIDIA/NemoClaw#13090 remain pending. |
|
All eight workflows and ten current checks are now successful on The targeted compatibility rerun, attempt 3, triggered by Pratik, passes Previously recorded Codecov upload HTTP429 and partial CodeQL/deprecation limitations remain. No absent automated review is claimed passing. This confirms CI qualification, not delivery or production QA acceptance: NVIDIA/NemoClaw#13090 still requires the corrected CLI through both reported UI paths and QA confirmation. |
When the Brev SSH Include is inside an unrelated
HostorMatchstanza,brev refreshfinds its text and leaves the alias unresolved. Only an Include in global scope now counts as installed, so the existing insertion path prepends a global Include. Existing configuration is preserved, and subsequent refreshes do not rewrite it again. Unix and Windows path matching remain supported.Related to NVIDIA/NemoClaw#13090 and its QA reproduction. This does not establish who originally misplaced the workstation Include.
The CI prerequisite #508 is merged and removes the enterprise-disallowed Slack action. Main already contains the auth-test expectation correction through #489. This candidate is synchronized onto main
ed8f392377849b701c13a110dad78debbb8a10f4; the SSH patch is unchanged (verified with git range-diff), and the PR still changes only two SSH files.Validation:
0c65a8fbe99b490739e4bc5e293db070b67f3ccbwith the updated base and dependencies. Full upstream CI, release cross-build and repository reviews remain required on the new head.The retained QA workstation still needs the corrected CLI tested through both original Setup over SSH and Coding Agent paths, refresh/reconnect, onboarding and a real agent response. This PR does not claim production acceptance or publish a CLI release.