Repository navigation
Capture playground clips with smooth deterministic motion - #515
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
Clip export encoded repeated screenshots when Chrome could not capture at 30 fps. The regression reproduced 33 distinct frames out of 210 on Mac and 141 on Linux.
What changed
How you verified
Top-level page animation is deterministic; media playback, worker clocks and animated child frames (#516) are outside this contract. Rendering can take longer than the clip duration on a slow host. The final three-second credit frame is intentionally held.
Reviewed head:
722f4837dda96ab00fb20e5df7c5ff4703ecf0e5; base:4155bd1646920415fa465470ef7b1fb75051ac4b. This changes headless export timing; decoded frame positions and the retained MP4s are the temporal evidence.Closes #514
Follow-up to #512 and the R3 spec tracked by #513. The washing-machine proof follows #508 and remains local.
BB-Thread-ID: thr_wgcdsffskf