Repository navigation
Make quick figures faster and preserve programmatic control values - #520
Merged
Merged
Conversation
brsbl
marked this pull request as ready for review
October 20, 2026 12:20
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated choice, string and boolean controls could accept input without changing their output. The parameter bridge now accepts primitive choice arrays and string/boolean declarations, preserves value types and numeric bounds, and ignores its own queued state messages in standalone previews. Regression tests exercise the actual bridge.
Quick explanations load a short workflow and parameter example, publish before one browser check, and keep the full Figure/Hero workflow behind explicit deeper requests. The launch observer now proves painted iframe content, checks frame identity/layout across capture, and wakes lazy frames before waiting for load. Screenshot-completion time is a conservative visible-card upper bound; status readouts count as output, while cosmetic controls still fail.
Final-head launch eval
All 20 prompts per provider ran once in fresh non-Git Personal threads on default models at
2ff907cc5adc65a16d6efc9974b2e2d08e5cd9a5. All 40 delivery screenshots and 63 automatically failed control verdicts were reviewed; real-input checks resolved harness gaps without rerunning agents or changing measured times.Both meet the stated launch bar (≥18 live, no questions, median ≤3 min, p90 ≤6 min). The existing strict harness still fails Claude's all-20 progress requirement: one settings answer showed only a final preface. Remaining generated-output failures are Claude's washer Replay and database Run query under reduced motion, and Codex's cosmetic settings navigation. These are retained failures, not waived controls.
Gate-1 reference: Claude 3.93/5.52 min, 19/20 live; Codex 1.46/1.70 min, 15/20 live. Claude first-tool→first-browser mean is 98 s across 18 mechanism figures (previously 171 s across 17). Current mean elapsed envelopes: startup 7 s, pre-publication 91 s, publication→browser 7 s, browser→visible 74 s. Different subsets, shared-host conditions and stronger capture proof prevent a controlled causal claim. Eight runs used the fixed 30-second render grace for 11–509 ms; all are logged within the unchanged 15-minute cap.
Validation
Bridge regression screenshots
Before:
7be5770a6c552eb4b5632ec11b259ef52f3700d5· After:2ff907cc5adc65a16d6efc9974b2e2d08e5cd9a5· Original 2× PNGs, identical fixture and input sequence. Before stays at choicea/ messageReady; after reachesc/Changedwith a booleantrueand changed output geometry.Closes #519
BB-Thread-ID: thr_vv8zgxmczt
Post-merge: main CI passed. Published release
f6818ad879ec2d29cf3df1d138b1c285c6389199has 85 shipped files that match the release artifact.