Repository navigation
fix(builtin): preserve trailing newline in fs.edit - #395
Merged
Merged
Conversation
`splitlines()` drops the final line terminator, so every edit stripped the file's trailing newline (e.g. ruff W292). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bub | a13d652 | Commit Preview URL Branch Preview URL |
Nov 04 2026, 01:09 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The built-in
fs.editrebuilds the file with"\n".join(text.splitlines()).splitlines()drops the final line terminator, so every edit strips the file's trailing newline, and linters then report it (e.g. ruffW292).Fix
If the original text ends with a newline, add one back when writing.
bub-acp-server's client-backedfs.editalready does this.Added
test_fs_edit_preserves_trailing_newline. It fails without the fix.🤖 Generated with Claude Code