Repository navigation
Build the UI image after tests pass, then ask infra for the deploy PR - #17
Merged
Merged
Conversation
image.yml now runs on workflow_run of test, only for pushes to main where test (UI checks + e2e) succeeded, and builds the tested head_sha. Previously it ran in parallel with the tests, so an image could be promoted for a commit whose e2e failed. A promote job then opens or refreshes the PR deploy/auth in bulbashenko-com/infra (the owner merges it). Cost: the image appears after e2e (~10-30 min) instead of right after the push. workflow_dispatch still builds the selected ref by hand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
image.yml now runs on workflow_run of test, only for pushes to main where test (UI checks + e2e) succeeded, and builds the tested head_sha. Previously it ran in parallel with the tests, so an image could be promoted for a commit whose e2e failed. A promote job then opens or refreshes the PR deploy/auth in bulbashenko-com/infra (the owner merges it). Cost: the image appears after e2e (~10-30 min) instead of right after the push. workflow_dispatch still builds the selected ref by hand.
Part of bulbashenko-com/infra#102. Merge it after that PR and after the org secret DEPLOY_APP_PRIVATE_KEY and variable DEPLOY_APP_CLIENT_ID exist. Until then the promote job fails, but the build still works.
🤖 Generated with Claude Code