-
Notifications
You must be signed in to change notification settings - Fork 10
Add --fail-on-error option to host link command #269
Copy link
Copy link
Open
Labels
Host 🏡Our `react-native-node-api-modules` packageOur `react-native-node-api-modules` packageLinking 🔗Discovering and copying prebuilds from packages into the hostDiscovering and copying prebuilds from packages into the hostenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
Activity
Metadata
Metadata
Assignees
Labels
Host 🏡Our `react-native-node-api-modules` packageOur `react-native-node-api-modules` packageLinking 🔗Discovering and copying prebuilds from packages into the hostDiscovering and copying prebuilds from packages into the hostenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
I've come cross this multiple times now, a package doesn't autolink and it's hard to figure out why.
In most cases it turns out to be
exportsbeing misconfigured, but this is not apparent sinceresolvePackageRootswallows any errors.Adding a
--fail-on-erroroption to fail and print any errors instead of silently disregarding them would be great.