fix(settings): validate info.relay_url is a usable absolute URL

[chappie-daemon]

Fixes #824

Problem

A info.relay_url that is not a valid absolute URL (e.g. nostream.example.com, no scheme) passed validateSettings() untouched, then broke every HTTP request: the CSP middleware in src/factories/web-app-factory.ts runs new URL(settings.info.relay_url) uncaught on every request, so /, /healthz, /readyz and the whole Admin Console returned 500 TypeError: Invalid URL — with no way to fix the setting from the UI.

Reported and diagnosed by @tarunagnihotri534 in #824 — the middleware omission and the new URL('localhost:8008') host quirk are his analysis. Thank you!

Fix

validateSettings() (src/utils/settings-config.ts) now rejects a relay_url that:

• is not a valid absolute URL (new URL() throws),
• parses with an empty host (scheme-only strings like localhost:8008 — new URL treats localhost: as the scheme and leaves the host empty), or
• has a protocol other than ws: / wss: / http: / https:.

One deliberate deviation from the snippet proposed in #824: the host check runs before the protocol check. With the protocol check first, localhost:8008 reports "must use ws, wss, http, or https protocol" — misleading, since its real problem is the missing host. Checking the host first gives each malformed shape its accurate message.

Tests

Four new cases in test/unit/utils/settings-config.spec.ts:

• accepts wss://, ws:// with port, https://, http://localhost:8008
• rejects nostream.example.com → "must be a valid absolute URL"
• rejects localhost:8008 → "must include a valid host"
• rejects ftp://nostream.example.com → "must use ws, wss, http, or https protocol"

Full unit suite green: 2187 passing (incl. the pre-existing settings-config and cli/config specs). biome lint clean, build:check clean.

[changeset-bot]

🦋 Changeset detected

Latest commit: 15a97d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
nostream	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Adds checks for info.relay_url in validateSettings.

• Relay settings now reject URLs the web server cannot use.

No actionable issues were found.

_{Reviews (1) · Last reviewed commit: "fix(settings): validate info.relay_url i..." · Reviewed by Greptile}

[coveralls]

coverage: 73.99% (+0.01%) from 73.979% — fix/relay-url-validation into main