Skip to content

ci(website): deploy on nostream-website release publish, not on main pushes - #834

Open
chappie-daemon wants to merge 6 commits into
mainfrom
fix/website-release-deploy
Open

chappie-daemon wants to merge 6 commits into
mainfrom
fix/website-release-deploy

Conversation

@chappie-daemon

Copy link
Copy Markdown
Collaborator

Change

Deploy Website no longer triggers on pushes to main. It now triggers on release published, filtered to nostream-website@ tags.

Flow after this change:

  1. Contributor adds a nostream-website changeset → PR → merge to main.
  2. changesets workflow opens/updates the release PR (changeset-release/main).
  3. Release PR merges → changesets tags nostream-website@X.Y.Z and publishes the GitHub release.
  4. That release event is the deploy trigger. Checkout on a release event is the tagged commit, so the deployed assets are the released build — deploy and release are the same artifact.

Relay-only merges (e.g. #830) never deploy the site. Relay image releases keep their v* gate in release.yml; the tag namespaces (v* vs nostream-website@*) don't overlap. workflow_dispatch stays for manual deploys of a chosen ref.

Note on the currently-failing run (38797428680)

That failure is independent of this change: check-hero-nips fails because #830 added NIP-77 (supportedNips 24 → 25) and the hero film still shows 24. The film re-render runs on the framefields GPU pipeline — the gpu-render container + authz carve-out from 2026-10-10 are no longer present on the host, so the render is currently blocked from the sandbox and needs the host-side containers/gpu-render/gpu-render-setup.sh --apply re-applied (or another GPU host). Until the film is re-rendered, the next nostream-website release will fail its site build at the guard.

…pushes

The site now deploys when the changesets workflow tags and publishes
nostream-website@X.Y.Z (the release event this workflow filters on).
Merging relay work to main no longer touches the site deploy; a site
deploy happens exactly when a release PR that bumps nostream-website
merges. Checkout on a release event is the tagged commit, so the
deployed assets are the released build. Relay image releases keep
their v* gate in release.yml — the tag namespaces do not overlap.

workflow_dispatch remains for manual deploys of main.
@changeset-bot

changeset-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 40540a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream-website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The changes appear safe to merge; the queue change addresses the previous finding without weakening deployment ordering.

Summary

Moves the website deployment queue from the workflow to the deploy job.

  • Only website deploy runs enter the website deploy queue.

No new actionable issues were found.

Reviews (2) · Last reviewed commit: "Merge branch 'main' into fix/website-rel..." · Reviewed by Greptile

Comment thread .github/workflows/deploy-website.yml
Greptile P1: with the release trigger, a v* relay release entered the
workflow-level deploy-website concurrency queue before the job's tag
filter rejected it, and as a queued entry it could replace a pending
website deploy (cancel-in-progress only protects the running one).
Concurrency moves to the job so rejected events never queue.
…eploy

# Conflicts:
#	.github/workflows/deploy-website.yml

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants