Repository navigation
Conversation
…dule from the single kernel library Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
…e15) - CharmState now requires s3_requirer (backups stack): build one S3Requirer before CharmState (ops permits a single instance per charm) and inject the same object into PostgreSQLBackups; switch backups imports to the lib path. - AsyncReplicationManager ctor grew the status/action bridges (set_unit_status, set_primary_status_message, set_app_status, create_pgdata, fix_leader_annotation, re_emit_relation_changed) and takes the watcher; wire the VM charm accordingly (K8s-only bridges stay no-ops). - Port tests/unit/test_async_replication.py to the manager-centric API (async_relation/unit_ip/get_shared_secret/remote_secret_id/ update_primary_cluster_data renames; flows moved to the manager) and fix the ruff I001 unsorted imports; repoint test_backups patch targets.
…stamp (DPE-11308)
…tion stack tip (88ebd95)
…tion stack tip (d98da6a) The library stack re-based after the AsyncReplicationWatcher Protocol removal; 8/8 now carries the 16.3.12 bump at d98da6a. Point the async manager's watcher bridge at the charm's watcher_handler - the lib handler satisfies the removed seam structurally.
…ion-vm' into dpe-10068-observer-manager
xavipg003
requested review from
carlcsaposs-canonical,
juju-charm-bot and
oleksii-buhaiov
October 16, 2026 15:01
marceloneppel
previously approved these changes
Oct 16, 2026
marceloneppel
previously approved these changes
Oct 19, 2026
dragomirp
reviewed
Oct 19, 2026
dragomirp
previously approved these changes
Oct 19, 2026
xavipg003
dismissed stale reviews from dragomirp and marceloneppel
via
October 26, 2026 18:47
22d37cb
dragomirp
previously approved these changes
Oct 26, 2026
marceloneppel
previously approved these changes
Oct 26, 2026
xavipg003
dismissed stale reviews from marceloneppel and dragomirp
via
October 27, 2026 16:01
bbdd157
dragomirp
approved these changes
Oct 27, 2026
marceloneppel
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
There is no integration coverage for deployments where the charm's own networking uses IPv6. Nothing proves the charm works when the peer binding resolves to an IPv6 address, on dual-stack networks, or that IPv4-only deployments keep working.
Solution
Add
tests/integration/test_ipv6_deployment.py. The scenario is selected withPG_IP_FAMILY:ipv6: re-discovers subnets (juju reload-spaces), creates anipv6space holding onlyPG_IPV6_SUBNETand sets it as the modeldefault-space, so every endpoint of the charm binds to IPv6.ipv4: IPv6 disabled on the LXD bridge (regression guard).dual: both families on the bridge, Juju picks the binding address.The tests check that:
network-get database-peersonly returns addresses of the expected family (inPG_IPV6_SUBNETforipv6);get-primaryaction succeeds, which exercises the Patroni REST API URL building.Add one spread task per scenario. Each task configures
lxdbr0(ipv6.address=fd42:1928:642::1/64ornone) before running the module.Pass
PG_IP_FAMILYandPG_IPV6_SUBNETthroughtox.iniso the test can read them.The fix itself is in the single kernel library (canonical/postgresql-single-kernel-library#377).
Also fixes #2073.