Skip to content

Stabilize integration tests - #898

Merged
holgpar merged 2 commits into
mainfrom
holger/stabilizeIntegrationTests
Oct 9, 2026
Merged

holgpar merged 2 commits into
mainfrom
holger/stabilizeIntegrationTests

Conversation

@holgpar

@holgpar holgpar commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Currently, for each CI run on a PR, we get failing integration tests.
The root cause is that the malware service does not answer to the scan request.

As a mitigation, I configured the test runner to retry failed tests. With the retry, we have a good chance to get a green job.
I also made the timeout configurable, but in the end decided to stay with the one minute timeout, because successful scans finish within seconds.

@holgpar
holgpar requested a review from a team as a code owner October 9, 2026 09:30
@holgpar
holgpar requested a review from tomk8r October 9, 2026 09:31
@hyperspace-pr-bot

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Improve Integration Test Resilience for Malware Scans

Bug Fixes

🐛 Stabilized integration tests affected by intermittent malware scan service timeouts. Generic integration tests now retry failed tests up to two times, while malware scan polling uses a configurable timeout that defaults to one minute.

Changes

  • .github/actions/integration-tests/action.yml: Added a configurable malware scan timeout input and enabled Maven Surefire retries for failing generic integration tests.
  • DraftOdataRequestValidationBase.java: Replaced hard-coded malware scan wait limits with the configured timeout and clarified the content validation result naming.
  • integration-tests/generic/src/test/resources/application.yaml: Added the default PT60S malware scan timeout configuration.

  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.32.6

  • LLM: gpt-5.6-sol
  • File Content Strategy: Full file content
  • Output Template: Default Template
  • Correlation ID: 22609f80-c3c4-11f1-88a1-0175817f3aed
  • Summary Prompt: Default Prompt
  • Event Trigger: pull_request.opened

@hyperspace-pr-bot hyperspace-pr-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configurable timeout is integrated consistently, but the action should safely pass the input and scope retries to malware-dependent tests so unrelated failures remain visible.

PR Bot Information

Version: 1.32.6

  • LLM: gpt-5.6-sol
  • File Content Strategy: Full file content
  • Correlation ID: 22609f80-c3c4-11f1-88a1-0175817f3aed
  • Agent Instructions:
  • Event Trigger: pull_request.opened

Comment thread .github/actions/integration-tests/action.yml
Comment thread .github/actions/integration-tests/action.yml
@holgpar
holgpar force-pushed the holger/stabilizeIntegrationTests branch from 0602bfe to 79a64b4 Compare October 9, 2026 10:52
tomk8r
tomk8r previously approved these changes Oct 9, 2026

@tomk8r tomk8r left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the PT60S suggestion: It might be slightly cleaner to use consistent units, but it's not critical.

The Hyperspace security suggestion should be committed.

Comment thread .github/actions/integration-tests/action.yml
@holgpar
holgpar force-pushed the holger/stabilizeIntegrationTests branch from 79a64b4 to a4535e3 Compare October 9, 2026 11:29
@holgpar
holgpar merged commit 0af5732 into main Oct 9, 2026
38 of 39 checks passed
@holgpar
holgpar deleted the holger/stabilizeIntegrationTests branch October 9, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants