Repository navigation
feat(signal): add bounded snapshots and guarded probes for SDK 1.1.0 - #2
Merged
Merged
Conversation
Add source-compatible optional diagnostics routes and typed schema-1 evidence, keep authorization separate, and share ordinary patch validation. Retain JSON protocol 1.3 with SDK metadata 1.1.0. Co-Authored-By: Codex <noreply@openai.com>
Accept complete 256 KiB responses in both client transports, reject invalid capture intervals without fabricating timestamps, and reject unsupported schemas before decoding authorization. Cover both actual transport paths with large-snapshot and future-schema regression tests. Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional signal evidence reads and guarded diagnostic patch writes for PatternSpace 2.3. Clients can read received values, app mapping, SDI software evidence and explicitly unknown physical signal fields through
device.signalSnapshot;pattern.displayProberequires a connection-bound host context guard and never falls back to ordinary patch writes.The change targets SDK 1.1.0 while retaining JSON protocol 1.3. Existing delegate conformers remain source-compatible through unsupported defaults, and missing optional capabilities decode as unsupported. Evidence schema 1 bounds samples and the complete response, rejects invalid capture times and unsupported major schemas, and keeps authorization outside shareable evidence. Both native and URLSession transports support the 256 KiB response limit; server request limits are unchanged.
Validation: fresh
swift testpasses all 184 tests (63 Core, 106 Server, 15 Client), with no warnings or errors. Coverage includes unchanged delegate fixtures, old host behavior, shared patch validation, guard errors, payload bounds, unsupported schemas and valid 100 KiB snapshots through both transports. Independent spec and quality reviews found no remaining P1/P2 blockers after corrections.Release validation: a fresh isolated
swift buildandswift testrun passed without warnings or errors. The release changelog is dated October 9, 2026. Merge and publication of SDK 1.1.0 are authorized; app release tagging remains separate.