Repository navigation
AArch64: Fixes missing memory operand access value for SWP - #3111
Open
Abhinavmadake wants to merge 1 commit into
Open
Abhinavmadake wants to merge 1 commit into
Abhinavmadake wants to merge 1 commit into
Conversation
changes CS_AC_INVALID to CS_AC_READ | CS_AC_WRITE for all 16 swp versions in arch/AArch64/AArch64GenCSMappingInsnOp.inc and CS_AC_INVALID to CS_AC_READ_WRITE in arch/AArch64/AArch64GenCSMappingInsn.inc, added new patch file and tests for the same
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checklist for this pull request
Detailed description
SWP reads old value from memory and writes the new one, But BaseSWP in llvm-capstone is missing mayLoad/mayStore
While checking for atomic instructions from #2589 i found that SWP's memory access was missing entirely
Fixes the per-operand access seen in the output for all 16 SWP instructions in arch/AArch64/AArch64GenCSMappingInsnOp.inc and per-instruction access in arch/AArch64/AArch64GenCSMappingInsn.inc.
Added suite/auto-sync/inc_patches/AArch64/03_swp_mem_access.patch following the workflow for patch files
Test plan
Added 4 tests covering 4 of the 16 instructions, for all 4 sizes(b/h/w/x) and all 4 ordering (none/a/al/l)
These tests pass with my fix, while they fail without it
Closing issues
-none