Repository navigation
Conversation
mpolitzer
force-pushed
the
fix/node-5
branch
from
November 13, 2026 14:37
bc7a615 to
7402c10
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the shared consensus detector and related CLI behavior changes.
No open issues 🎉
What changed in this PR
This PR centralizes EIP-165 consensus detection for the CLI, replacing quorum-method probing in application registration and deployment while sharing the detector with contract inspection.
Changes:
- Adds shared consensus classification, model mapping, and Quorum validator checks.
- Makes registration’s
--prtflag assert the detected type and rejects PRT addresses in deployment’s--consensuspath. - Updates tests and documents the CLI behavior changes.
| File | Description |
|---|---|
pkg/ethutil/detect_consensus.go |
Adds shared EIP-165 detection and Quorum validation. |
pkg/ethutil/detect_consensus_test.go |
Tests classification, probe failures, mappings, and validator checks. |
cmd/cartesi-rollups-cli/root/deploy/broadcast_test.go |
Adds interface-probe responses to the deployment test backend. |
cmd/cartesi-rollups-cli/root/deploy/application.go |
Uses shared detection and rejects custom PRT consensus addresses. |
cmd/cartesi-rollups-cli/root/deploy/application_test.go |
Tests probe errors and rejected consensus types. |
cmd/cartesi-rollups-cli/root/contract/contract.go |
Delegates inspection detection to the shared helper, preserving call options. |
cmd/cartesi-rollups-cli/root/contract/contract_test.go |
Removes tests relocated to the shared detector package. |
cmd/cartesi-rollups-cli/root/app/register/register.go |
Detects consensus before parameter reads and treats --prt as an assertion. |
cmd/cartesi-rollups-cli/root/app/register/register_test.go |
Replaces quorum-probe tests with PRT assertion tests. |
CHANGELOG.md |
Documents detection and flag behavior changes. |
Review effort: Balanced
mpolitzer
marked this pull request as ready for review
November 13, 2026 17:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition
--prtflag now asserts the consensus is PRT.