fix: refactor cli output-path resolution out of the core layout model - #481
Merged
cdsap merged 1 commit intoSep 20, 2026
Merged
Conversation
cdsap
deleted the
issue/480-hermes-refactor-cli-output-path-resolution-a1
branch
September 20, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
project-generator/src/main/kotlin/io/github/cdsap/projectgenerator/model/ProjectLayout.ktcontainsdefaultRootPath, including the CLI-specificprojects_generated/<projectName>convention.cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateProjectRequest.ktcalls this core-model function while assembling a CLI request.Why this matters
The published generator core is coupled to a CLI filesystem convention, making output policy harder to reuse or test independently. It also mixes two boundaries in
ProjectLayout: core language-specific layout attributes and CLI default-directory selection.Proposed change
Move
defaultRootPathinto a small CLI-ownedProjectOutputPathResolverand updateGenerateProjectRequest.resolveto use it. KeepProjectLayout.languageAttributesunchanged for the generator's internal layout behavior.Notes
This is a small dependency-direction improvement: the CLI chooses its delivery/output policy, while the core generator retains only layout behavior needed to generate a project. The change follows a clean-architecture boundary without introducing a new framework or broader redesign.
Fixes #480
Changes
cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateProjectRequest.ktcli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/ProjectOutputPathResolver.ktcli/src/test/kotlin/io/github/cdsap/projectgenerator/cli/GenerateProjectsCliTest.ktproject-generator/src/main/kotlin/io/github/cdsap/projectgenerator/model/ProjectLayout.ktproject-generator/src/test/kotlin/io/github/cdsap/projectgenerator/model/ProjectLayoutTest.ktVerification
./gradlew :project-generator:unitTest./gradlew :cli:test./gradlew ktlintCheck