fix: refactor generate-project resolution to use a cohesive options obje - #483
Merged
cdsap merged 1 commit intoSep 21, 2026
Merged
Conversation
cdsap
deleted the
issue/482-hermes-refactor-generate-project-resolution-a1
branch
September 21, 2026 20:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
GenerateProjectRequest.resolve in cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateProjectRequest.kt accepts 14 positional parameters, mixing CLI input, version resolution, validation, and output-path policy. Main.kt must mirror this long parameter list, making additions prone to ordering mistakes and increasing coupling at the CLI boundary.
Why this matters
The current signature is difficult to read and test, and a new CLI option requires coordinated edits with little compiler protection against mis wiring.
Proposed change
Introduce a GenerateProjectOptions value object containing the raw resolved CLI inputs, change GenerateProjectRequest.resolve to accept that object, and update Main.kt and focused tests to construct it. Keep version precedence, validation, default naming, output paths, and generated-project behavior unchanged.
Notes
This treats the CLI command as an application-boundary input and keeps domain configuration resolution behind one explicit command object, improving testability without introducing a new framework or changing the core generator.
Fixes #482
Changes
cli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/GenerateProjectRequest.ktcli/src/main/kotlin/io/github/cdsap/projectgenerator/cli/Main.ktcli/src/test/kotlin/io/github/cdsap/projectgenerator/cli/GenerateProjectsCliTest.ktVerification
./gradlew :project-generator:unitTest./gradlew :cli:test./gradlew ktlintCheck