Repository navigation
ci(docs): build the live demo from the released vsix - #1159
Merged
Merged
Conversation
lcottercertinia
previously approved these changes
Oct 8, 2026
lukecotter
force-pushed
the
feat-docs-demo-vsix
branch
from
October 8, 2026 10:27
c63a8a8 to
aa9bc37
Compare
lcottercertinia
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
The publish workflow built the live demo from a second checkout of the latest stable release. It installed that checkout's dependencies, then rebuilt the viewer with
NODE_ENV=production pnpm run build:dev, because old releases have nobuild:prod. The demo then ran a rebuild of the release, not the release itself.This PR downloads the released vsix from Open VSX and builds the demo from it. The demo now runs the same bytes that users install.
🛠️ Changes made
FinancialForce/lanaat the release tag from Open VSX. It asks by version, because Open VSX'slatestcan be a pre-release.$RUNNER_TEMP/releaseand renamesextensiontolana, sobuild-demo.mjsreads it with no code change.build:devworkaround.Test Demo Hostruns withoutDEMO_VIEWER_ROOT. The test scanslog-viewer/src, and the vsix does not have it. So publish now checks main's host against main's viewer, not against the released viewer.build-demo.mjsandlana-docs/README.md:DEMO_VIEWER_ROOTcan now be any folder with a builtlana/outandlana/package.json, such as an unzipped vsix.🧩 Type of change (check all applicable)
🔗 Related Issues
Follows #1147.
✅ Tests added?
👍 yes
🙅 no, not needed
🙋 no, I need help
The download step, run locally for 1.22.1, gives
lana/outandlana/package.json.The site builds from it, and
pnpm --filter docs-site testpasses.The demo's
bundle.jsis byte-identical to the one in the 1.22.1 vsix.📚 Docs updated?
🧪badge — see RELEASING.md)Anything else we need to know? [optional]