Repository navigation
fix(lana): tell the user when Salesforce Services lacks the Apex log API - #1162
Merged
Merged
Conversation
lcottercertinia
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Follows #1161. When the installed Salesforce Services did not have a method that lana calls, Retrieve Log did nothing and showed no message.
There were two causes, and they come from one mechanism:
undefined.isSalesforceServicesApi) read the methods from those tags, so the check always passed.RetrieveLogFilethen read theundefinedresult as "the user closed the picker", and stopped with no message.This PR makes the check look at the real service instances in
prebuiltServicesDependencies. A Services version without the API now gets lana's existing message, the same notification as when Services is not installed:🛠️ Changes made
servicesRuntime.ts:isSalesforceServicesApigets each service from the Effect context by its tag, and checks the methods on that instance.servicesRuntime.test.ts:Effect.Servicetags with accessors, as Services does.test/playwright/support/logAnalysis.ts:openLogAnalysisusesexecuteCommandWithCommandPalette, as the Retrieve Log spec does.🧩 Type of change (check all applicable)
🔗 Related Issues
Follows #1161.
✅ Tests added?
👍 yes
🙅 no, not needed
🙋 no, I need help
The two new unit tests fail with the old check and pass with the new one. All 338 lana tests pass.
Both web e2e specs pass with the real Services extension.
With a method name that Services does not have, the e2e run shows the "Update it" notification above, and the Retrieve Log spec fails, as it should.
📚 Docs updated?
🧪badge — see RELEASING.md)Anything else we need to know? [optional]
salesforceServices.tsstill calls them through the accessor tags. So a method added later, but not added to the check, would again giveundefinedand not an error.