Repository navigation
fix(log-viewer): make current find match in the tables standout more on all themes - #1165
Merged
Merged
Conversation
…tor does In some themes the current find match in a table looked the same as the other matches. One theme sets the 2 find colours to rgba(39, 103, 130) at alpha 0.56 and 0.5. The editor tells them apart because it also selects the current match: its selection colour lies under the find colour. - Find adds the current match's range to a third highlight, `current-find-match-under`, below the current-match highlight. The priorities set the order of the 3 layers. - The global styles give it editor.selectionBackground, with the system Highlight colour outside VS Code. Not the inactive selection colour that the editor shows while its find box has focus: in that theme it made the current match too faint to tell apart.
lcottercertinia
changed the title
lcottercertinia
approved these changes
Oct 9, 2026
5 of 15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
In some themes, the current find match in a table looked the same as the other matches. This PR makes it stand out, as it does in the editor.
One theme sets the 2 find colours to
rgba(39, 103, 130)at alpha 0.56 (current) and 0.5 (other matches). The editor tells them apart because it also selects the current match, so its selection colour lies under the find colour. The tables drew only the find colour.🛠️ Changes made
current-find-match-under, below the current-match highlight. Highlight priorities set the order of the 3 layers. A::highlightcannot draw a border, so a second painted layer is the least it takes.editor.selectionBackground, with the systemHighlightcolour outside VS Code. It follows theme changes like the other find colours.editor.inactiveSelectionBackground, which the editor shows while its find box has focus: in that theme it made the current match too faint to tell apart.🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
🔗 Related Issues
✅ Tests added?
📚 Docs updated?
🧪badge — see RELEASING.md)Anything else we need to know? [optional]