Repository navigation
feat(log-viewer): show the Inspector tables in lv-grid - #1173
Merged
Merged
Conversation
lukecotter
force-pushed
the
feat-analysis-lv-grid
branch
from
October 16, 2026 09:10
5344e58 to
83a6582
Compare
lukecotter
force-pushed
the
feat-inspector-lv-grid
branch
from
October 16, 2026 09:10
96bd81f to
ca9e923
Compare
lukecotter
force-pushed
the
feat-analysis-lv-grid
branch
2 times, most recently
from
October 16, 2026 14:51
29c3236 to
f2eab46
Compare
…urce deselect() returns true when it cleared a selection. goTo and setCurrentMatch wait for a source set in the same turn. The Calc docs say the scope is read on each run.
…y columns The controller holds the hover locate, the pick, the row menu, the marks and the Escape drop of an Inspector grid. The inline query column and the Calls column are shared, and the Database tables use the inline query column.
The Call Stack, Call Tree and Database time sections use lv-grid. Remove the code that only the Tabulator tables used. The Tabulator half of locatedRow.ts stays until Tabulator is removed, because the grid bench's Tabulator contender imports it. Refs #1169
lukecotter
force-pushed
the
feat-inspector-lv-grid
branch
from
October 16, 2026 14:55
ca9e923 to
606c4cd
Compare
lcottercertinia
previously approved these changes
Oct 16, 2026
…he user made lv-grid-select reports user: true for a click or a key. A goTo that waits for its path to open no longer selects when a newer goTo, a deselect, a click or a key selected in the meantime.
…frame is selected The Inspector tables kept the echo guard up for the whole of a select that waits for its path to open, so a click in that time was lost and the selection went back to the active frame. They now count only the selections the user made.
…lectActive It moves the selection, where a mark in the Inspector is the hover highlight.
lcottercertinia
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1169.
What changes
The three Inspector tables move from Tabulator to lv-grid:
All three share one controller for these features:
User-visible changes
Commits
feat(grid): these changes support the Inspector tables.deselect()returns whether it cleared a selection.goTowaits for a source set in the same turn.refactor: the shared Inspector grid controller, and the inline query and Calls columns. The Database tables use the same inline query column.feat: the Inspector tables on lv-grid. The code that only the old tables used is removed.feat(grid): agoTogives way to a newer goTo, a deselect, a click or a key. The select event says whether the user made it (user).fix: the Inspector hears a click made while the active frame is still being selected. The controller now reports a pick only when the user made the select.refactor:markActiveis renamedselectActive.fix: each Inspector grid has a label for a screen reader.docs(changelog): the Tables entry names the Inspector tables. It makes no new speed claim.refactor: the controller listens for the grid events itself. The hosts no longer bind them.refactor: the controller marks the rows again whenever the grid's rows change. The hosts no longer callremark().refactor: the Tabulator row marker is removed fromlocatedRow.ts.stampRowPathstays, because the grid bench's Tabulator contender uses it.refactor: the Inspector Calls columns usecountColumn, like the main tables.callsColumnis removed.fix: a row with no frame leaves the browser's menu.refactor: the marks are compared withsameMembers.refactor(grid):setCurrentMatchno longer waits for a new source. Its matches come from the rows found before.test: the query and time columns.test: test steps that other tests already cover are removed.test: the Inspector menu, picks and marks.Tests
pnpm lint: passpnpm test: 2996/2996 pass (log-viewer: 2627)lv-grid.tsto within 4 ms on every step. Find is 504 ms on this branch and 506 ms on main. CSV export is 760 ms on both. No frames are dropped.pnpm test:e2e:web: 2/2 pass before the rebase onto main. It was not run after the review commits. CI runs it.