Repository navigation
fix(log-viewer): leave zero-duration top-level lines out of the Inspector call tree - #1182
Merged
Merged
Conversation
…ctor call tree With nothing selected, each top-level event was kept whatever its duration, as a selection is. A line such as USER_INFO then showed as a row with no time.
lcottercertinia
approved these changes
Oct 16, 2026
lcottercertinia
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With nothing selected, the Inspector call tree showed zero-duration top-level lines as rows with no time, for example
USER_INFO.Cause
The whole-log tree built each top-level event with
realSubtree, which keeps its root whatever its duration, as a selection is kept.Fix
subtreeRootstakes adropEmptyoption. Only the whole-log tree turns it on: it leaves out a top-level row that has no duration and nothing timed below it. A selection still always shows. The Call Tree tab still showsUSER_INFOas a row.Tests
pnpm lint: passpnpm test: 2881/2881 pass, after merging main (refactor(log-viewer): remove Tabulator #1174)CHANGELOG
No entry. The
USER_INFOrow is itself unreleased, so this most likely never reached users.