Repository navigation
ENT-14731: Added reactor github actions job and test suite outline - #6421
Merged
Merged
Conversation
victormlg
force-pushed
the
cf-reactor.Tests
branch
3 times, most recently
from
October 19, 2026 11:11
f1a7692 to
a470653
Compare
victormlg
changed the title
victormlg
force-pushed
the
cf-reactor.Tests
branch
from
October 19, 2026 12:47
a470653 to
1ad7654
Compare
olehermanse
reviewed
Oct 19, 2026
olehermanse
reviewed
Oct 19, 2026
olehermanse
reviewed
Oct 19, 2026
olehermanse
reviewed
Oct 19, 2026
- added verbose output when file is detected inside file_watcher, for the test to read - created a parallel github actions job for reactor tests - created a reactor test suite, with helper functions and main 'run' script Ticket: ENT-14731 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.Tests
branch
from
October 20, 2026 08:34
1ad7654 to
78d6b7b
Compare
larsewi
approved these changes
Oct 20, 2026
Contributor
|
Make sure to run shellcheck and shfmt on it ;) |
Contributor
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14830/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14830/ |
Contributor
Author
I did! I got some warnings but the fix looked very hard to read or needed to be canceled with comments. I thought that since no test runs shellcheck on these, its' ok to leave it like that |
larsewi
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outline of how to test cf-reactor. For now, the only test is for the file deleted event type, using variables. More will be added in a follow-up PR.