Skip to content

Revert: cf-execd: dot-stuff mailed agent output lines starting with '.' #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsewi merged 1 commit into from
Oct 20, 2026
+1 −49
Merged

Revert: cf-execd: dot-stuff mailed agent output lines starting with '.' #6427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions cf-execd/cf-execd-runner.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,11 +797,7 @@ static void MailResult(const ExecConfig *config, const char *file)
{
continue;
}
/* Dot-stuff lines starting with '.' (RFC 5321, section 4.5.2), or a
* lone "." in the output would end the DATA section early and the
* remaining lines would be read by the server as SMTP commands. */
if ((line[0] == '.' && send(sd, ".", 1, 0) == -1) ||
send(sd, line, n_read, 0) == -1 ||
if (send(sd, line, n_read, 0) == -1 ||
send(sd, "\r\n", 2, 0) == -1)
{
Log(LOG_LEVEL_ERR, "Error while sending mail to mailserver "
Expand Down
44 changes: 0 additions & 44 deletions tests/acceptance/25_cf-execd/mail_dot_line.cf
View file
Open in desktop

This file was deleted.

Loading