Skip to content

Fixed out-of-bounds read of extended attribute values in filestat() #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dhanu-dynamic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed out-of-bounds read of extended attribute values in filestat() #6429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libpromises/evalfunction.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5193,7 +5193,7 @@ static FnCallResult FnCallFileStatDetails(ARG_UNUSED EvalContext *ctx,
}

char data[CF_BUFSIZE];
int datasize = lgetxattr(path, current, data, sizeof(data));
int datasize = lgetxattr(path, current, data, sizeof(data) - 1);
if (datasize < 0)
{
if (errno == ENOTSUP)
Expand All @@ -5208,6 +5208,8 @@ static FnCallResult FnCallFileStatDetails(ARG_UNUSED EvalContext *ctx,
}
else
{
data[datasize] = '\0';

if (!StringIsPrintable(data))
{
Log(LOG_LEVEL_INFO, "Skipping extended attribute of '%s', it has non-printable data: '%s=%s'",
Expand Down
Loading