Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Computing a genotype array or vector with a mask or phasing annotation currently fails:
da.computereturns values, mask and phasing in the requested order, but the wrapper consumes them from the end. Consume from the front instead. The result retains the original integer genotypes, mask and phasing; unannotated computation is unchanged.Regressions cover arrays/vectors, haploid/diploid/triploid calls, missing calls and all four annotation combinations. Eighteen cases fail before and all 24 pass after.
Also replayed 512 observed 1000 Genomes chromosome-22 variants across 2,504 samples through Zarr, three chunk layouts, slices and vectors. All 39 wrapper cases pass here versus nine on main and released 1.3.13. Values and observed phase flags match an independent VCF parser. A deliberately constructed QC mask, allele counts and pairwise diversity match independent NumPy calculations. Twelve existing direct-count controls stay unchanged.
Validation: full Python 3.12 / NumPy 1.26 suite passes, 905 tests; Python 3.10 / NumPy 2.2 Dask tests and the same recorded-data workload also pass. CI lint passes. This is independent of the copy repair in #460.