Repository navigation
feat(compat): support DSH 0.2.2-alpha.3 and 0.2.2-rc.1 - #29
Merged
Merged
Conversation
cherrchen
marked this pull request as ready for review
November 11, 2026 07:34
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
Owner
Author
|
Addressed the review flag: the composer tooltip test now hovers the anchor and asserts the bubble host — where the installed Tooltip supports , the render container (without ) where it does not. It fires both mouse- and pointer-event paths so the pointer switch is covered. Refreshed the 23-lane matrix evidence (1043 tests per lane) and pushed ; CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the verified compatibility range from
0.2.2-alpha.2to the latestdsh-v0.2.2-rc.1by adding the two releases in between:0.2.2-alpha.30.2.2-rc.1The development pin and committed lockfile stay on
0.2.0-rc.2.Interface review (upstream tags)
dsh-v0.2.2-alpha.2→dsh-v0.2.2-alpha.3: 2315 files changed. This is a real feature release: the host runtime moves to Cordis4.0.6-alpha.2/ schemastery3.18.6-alpha.2, the host vendor sources pick up the Cordis 4.1.0 changes, and the client ships the new context menu package and plugin-manager config slots.dsh-v0.2.2-alpha.3→dsh-v0.2.2-rc.1: 387 files, a release-version-only republish (111 seam manifests, one version line each). It moves the host runtime to Cordis4.1.0/ schemastery3.19.0.The packages this plugin consumes were checked against the plugin's actual seams:
resolveExecutable,spawn, argv handling and the credentials key/ref contract are unchanged.dsh-llmmakesGenerateOptionsgeneric with an empty defaultLlmRequestPurposeMap; the plugin never passedpurpose, andstreamtext-delta/currentSelection()keep their shape.changes[]);SessionSummary.cwdandprojectionValuesare unchanged, soeffectiveWorkspacePathkeeps working.contextMenus,openResource.destinationandSidebarRightTabInfo.panel.isFloating. The plugin callsopenTab/openResourcewithout placement overrides and reads onlytabfromuseTabInfo().settings.section.icon;configForms.get, the volatile reference semantics andplugins.bundle.configregistration are unchanged.Menucontextual options,MENU_TRANSITION_MS,useMarkdownDelegate, save icons).DiffBlock,diffTotals,MarkdownText,Toast,Modal,Tag,Switch,Pilland every Medium glyph keep their contracts.Adaptation
0.2.2-alpha.3makes the docked composer seat a containing block for fixed descendants (will-change: transform), and the host now requires fixed overlays in the composer to portal todocument.body. The branch/changes tooltip inconversation.input.leftnow goes throughsrc/compat/dsh-tooltip.tsx, which probes the installed Tooltip signature (portalexists from0.1.7-alpha.1) and forwardsportal: truewhere supported. The0.1.5/0.1.6copies ignore the extra prop.SUPPORTED_DSH_RELEASESandCREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR, andengines.dsh.|| ~4.0.6-alpha.2to the Cordis peer and|| ~3.18.6-alpha.2to the schemastery dependency so the exact declared-floor gate accepts alpha.3. rc.1's stable4.1.0/3.19.0fall inside the existing base ranges.0.2.2lane now uses Node24.9.0; older hosts stay on22.19.0.@deepseek-ai/dsh-client-ui-context-menuonly exists from alpha.3 and is a runtime import of sidebar-right; adding it to a range covering older hosts would break their app-boot preflight. The host composition provides it, and the plugin source does not import it.Validation
0.2.2-rc.1first passed as an unlisted candidate (DSH_COMPAT_MODE=warn) across all gates.0.2.2-alpha.3's first candidate failed only the compat gate because the old ranges rejected the host copies4.0.6-alpha.2/3.18.6-alpha.2; after adding the OR clauses its formal lane passed every gate.0.2.2-rc.1. (An earlier rc.1 run flaked on one accounts dialog test; that test passes in isolation and on the final run.)document.bodywhere the installed Tooltip supportsportal, the render container withoutdata-portalwhere it does not. This replaces the probe-only assertion raised in review.docs/reference/dsh-adaptation-20261111.json.Not covered
CI passed after the review follow-up.