Repository navigation
Conversation
cherrchen
force-pushed
the
feat/adapt-1111-rc2
branch
4 times, most recently
from
November 11, 2026 15:16
7bffdac to
6185176
Compare
- Add 0.2.2-rc.2 to the release list, every DSH peer OR, engines.dsh and the optional credentials subset. Its Cordis 4.1.0 / cosmokit 1.9.0 / schemastery 3.19.0 copies match rc.1 and stay inside the declared ranges. - Route the commit-options dropdown through src/compat/dsh-menu.tsx: rc.2 removes Menu.getAnchorRect for the CSS anchorRef, earlier copies measure the callback, so the compat layer probes whether the installed Menu still reads getAnchorRect. 0.2.2-alpha.3 through rc.1 also name an internal anchorRef option, so that name alone does not identify the interface. - Run the 0.2.2-rc.2 CI lane on Node 24.9.0 with the other 0.2.2 hosts. - Document the seam review in the compatibility contract. Lane evidence is pending because the rc.2 npm packages are not published yet.
cherrchen
force-pushed
the
feat/adapt-1111-rc2
branch
from
November 11, 2026 15:29
6185176 to
95681c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the verified compatibility range from
0.2.2-rc.1to the upstream tagdsh-v0.2.2-rc.2, the current0.2.2release candidate. The development pin and committed lockfile stay on0.2.0-rc.2.This PR is a draft because the
0.2.2-rc.2npm packages are not published yet. The GitHub Release exists (2026-11-11) but@deepseek-ai/dsh@0.2.2-rc.2is absent from the registry (latest is still0.2.2-rc.1), so the isolated lane cannot install the host and the compatibility matrix lane for this version stays red until publication. The declaration and the code adaptation are ready; the lane evidence is not.Interface review (upstream tags)
dsh-v0.2.2-rc.1(66491b05e3) →dsh-v0.2.2-rc.2(ddac96760b): 4645 files changed in the tree; the directories this plugin consumes contain 1001 changed files. This is a real feature release (menu positioning and submenus, session history paging and retry, worktree archive cleanup, Forge and Agent Team panels), not a version-only republish. No packages were added or removed between the tags.The packages this plugin consumes were checked against its actual seams:
dsh-client-ui-primitivesremovesMenu.getAnchorRectand theuseAnchoredPosition/AnchoredPositionOptionsexports; portal menus now use CSS Anchor Positioning viaanchorRef/anchorPoint(upstream upgrade guidev0.2.2-alpha.2/css-anchored-menus).hocslot kind and renderer layers,conversation.hero.frame, composer file-intake route,insertQuote(text, summary?),openSettings(sectionId?),Modal.tone,QuotePreview.summary, new icons. The slots and props Git registers or reads keep their contracts.dsh-subprocess/error.ts(SubprocessError, stable codes); a pre-aborted spawn now throwsAbortErrorand empty argv throwsSUBPROCESS_INVALID_ARGV.resolveExecutable,spawn,CollectedOutputand platform rejections are unchanged.CredentialInfo.maskedadded (optional) — the DeepSeek account provider rewrite stays host-internal;WorkingDirectoryErrorcodes and aworking-directory/accesswaterfall,get/setunchanged; worktree archive cleanup recordsplugin:worktree/createdbutcreate(agent, request, signal)is unchanged;dsh-fsaddsFS_ALREADY_EXISTS/fsErrorFromErrnoonly,resolve/lstat/writeTextunchanged.AgentRegistrydropsparentAgent,isOwnedBy,roots()(Git only callsagents.get). Session snapshots gain history fields;SessionSummary.cwd/projectionValuesunchanged.LlmErrorcodes are tightened;streamtext-delta/GenerateOptionsunchanged.4.1.0, cosmokit1.9.0, schemastery3.19.0— the same copies as0.2.2-rc.1, already inside the declared ranges. No new OR clause.Adaptation
src/compat/dsh-menu.tsxaddsAnchoredMenu, which supplies the anchor input the installed release reads. The probe asks whether the installedMenustill reads the removedgetAnchorRect:0.2.2-alpha.3throughrc.1also use an internalanchorRefoption in their positioning hook, so the newer prop's presence alone misidentifies those releases (the first matrix run caught exactly that).src/client/details/CommitRegion.tsxnow hands over the chevron's ref instead of a measuring callback. The other four Git menus render their trigger inline, so they need no anchor input.0.2.2-rc.2is added toSUPPORTED_DSH_RELEASES,CREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR andengines.dsh.0.2.2-rc.2lane joins the other0.2.2hosts on Node24.9.0.Validation
Development pin
0.2.0-rc.2:pnpm compat:check— list, peer ORs,engines.dsh, dev pins and installed packages agree.pnpm test— 1047 passed (1043 before; 4 new).pnpm docs:check— passes.pnpm buildandpnpm test:artifact— 7 artifact checks pass; the packed tarball contains the compat module and type declaration.pnpm pack— producesdsh-electron-dsh-plugin-git-0.2.9.tgz.tests/dsh-menu.client.spec.tsxcovers both anchor shapes as pure functions and asserts per installed host that the portal list lands on the supplied trigger rect (legacy branch) or publishes it as the CSS anchor (new branch). The suite was also run locally against the real publisheddsh-client-ui-primitivesbundles of0.1.5-rc.2(oldest supported host) and0.2.2-rc.1(the release whose internalanchorRefoption broke the first probe), in addition to the development pin.data-menu-materialattribute, plus0.2.2-alpha.3/rc.1where the probe misidentified the interface); the probe and the test selectors were corrected and re-verified as above.The compatibility contract records the seam review and this evidence gap:
docs/reference/dsh-compatibility.md.CI results
data-menu-materialattribute, plus0.2.2-alpha.3/rc.1where the probe misidentified the interface); after the fix every supported lane is green.verify (0.2.2-rc.2)fails atupgrade-dsh.mjswith the expectedE404 No match found for version 0.2.2-rc.2.peers check,compat:check, the full test suite and the three acceptance replays, then fails fetching Ubuntu packages forplaywright install --with-deps chromiumwithTemporary failure resolving 'azure.archive.ubuntu.com'— a runner DNS failure unrelated to this change (identical on two runs).Pending / not covered
0.2.2-rc.2lane and browser lane: blocked on npm publication. After it is published: dispatchDSH compatibility matrixwith version0.2.2-rc.2(candidate warn mode first), then run the formal matrix and the isolated browser lane, add the evidence to the compatibility contract, and mark this PR ready.0.2.2-rc.2(the host cannot be installed yet).