Repository navigation
build(deps-dev): bump jsdom from 30.1.3 to 31.0.0 - #534
dependabot[bot] wants to merge 1 commit into
Conversation
Deploying podnotes with
|
| Latest commit: |
ab2ff0b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://14a8f413.podnotes.pages.dev |
| Branch Preview URL: | https://dependabot-npm-and-yarn-jsdo-tkd1.podnotes.pages.dev |
There was a problem hiding this comment.
Not mergeable as a lockfile-only bump. jsdom 31.0.0 replaces CSS parsing, selector matching, and computed styles; src/ui/PodcastView/styles.test.ts is written against jsdom 30 serialization and fails 10 of 16 cases. GitHub Test / Unit tests is red. Plugin runtime is untouched (jsdom is test-only), so this needs a dedicated assertion migration, not Dependabot.
Bump: jsdom 30.1.3 → 31.0.0 (package.json + lockfile). Published 2026-11-05; 7-day cooldown is satisfied. Title is build(deps-dev): and will not cut a release.
What passed (Node 22.23.4): npm ci (lockfile unchanged), lint, format:check, typecheck, build, size (318892 raw / 103371 gzip, same as #530). npm audit --omit=dev 0. Remaining 127 unit files / 2816 tests pass. Six style cases still pass (unguarded :hover scan, tablet padding, disabled opacity, search-field padding).
What failed (local and CI):
| Case | jsdom 30.1.3 | jsdom 31.0.0 |
|---|---|---|
play/card transition |
transform 120ms ease |
transform 0.12s |
play/card animation |
"" |
none |
| EQ bars | "" / pn-eq 1s ease-in-out infinite |
all / 1s ease-in-out -0.8s infinite pn-eq |
focus outline |
2px solid var(--interactive-accent) |
3px rgb(0, 0, 0) (UA default; unresolved var() dropped) |
hover background-color: var(--background-modifier-hover) |
preserved custom property | rgba(0, 0, 0, 0) |
| skip-button rest | rgba(0, 0, 0, 0) |
rgb(204, 204, 204) |
transcript label display |
inline |
block |
artwork box-shadow |
var(--shadow-s) |
currentcolor none |
The hover workaround that retargets background: var( to background-color: var( (added after #515) no longer keeps unresolved custom properties. Same class of failure as #515, worse (10 vs 5).
Do not merge until styles.test.ts is migrated to jsdom 31’s computed-style serialization (and the hover/outline/shadow var() behavior is re-proven, not just retuned). Keep this PR as the version bump only if that migration lands with it; otherwise close in favor of a dedicated PR.
Sent by Cursor Automation: Dependabot PRs
| "acorn": "^8.19.0", | ||
| "eslint-plugin-obsidianmd": "^0.4.2", | ||
| "jsdom": "^30.1.3", | ||
| "jsdom": "^31.0.0", |
There was a problem hiding this comment.
jsdom 31.0.0 is a CSS-engine major. This pin is the only source change, and it reds src/ui/PodcastView/styles.test.ts (10/16) on both this checkout and GitHub Unit tests. Do not land the version bump until those assertions are migrated.
Bumps [jsdom](https://github.com/jsdom/jsdom) from 30.1.3 to 31.0.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v30.1.3...v31.0.0) --- updated-dependencies: - dependency-name: jsdom dependency-version: 31.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
d75b765 to
ab2ff0b
Compare


Bumps jsdom from 30.1.3 to 31.0.0.
Release notes
Sourced from jsdom's releases.
Commits
825fa8e31.0.09f2e49aAdd ariaBrailleLabel and ariaBrailleRoleDescription4c0a35eFlush text written with document.write()fce11d3Switch canvas support to@napi-rs/canvas27614bfFix document.hasFocus() during focus changes627ade2Implement asynchronous focus fixup8bd17a2Implement reportError()5ae66cfUpdate webidl2js and remove IDL workaroundsce5a100Align development scripts and CI9cc717fAdopt ESLint config v6 and oxfmt